fix(avoid-inline-spacing): add spacing threshold #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Jul 20, 2022
| }); | ||
| }); | ||
|
|
||
| (isIE11 ? xit : it)('is false when `initial` (meaning `normal`) is used along with !important', function () { |
There was a problem hiding this comment.
Thanks for the parenthesis meaning, super helpful.
| assert.isNull(checkContext._data); | ||
| }); | ||
|
|
||
| (isIE11 ? xit : it)('is false when below 1.5em and !important', function () { |
There was a problem hiding this comment.
Beat me... IE reported the value as 0.19. Guess IE just cannot count. Didn't think it worth debugging since we're pulling IE soon.
test/integration/rules/avoid-inline-spacing/avoid-inline-spacing.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven Lambert <[email protected]>
WilcoFiers
commented
Aug 8, 2022
| The cheese grater is in the way! | ||
| </p> | ||
|
|
||
| <!-- CSS keywords --> |
There was a problem hiding this comment.
I didn't add "initial", since IE chokes on that. It's covered by unit tests anyway.
straker
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #3467